client: suspicious assertion in asyncns.c

[Ralf Jung]

Building the client local shows a warning that seems legit at first glance:

In file included from /home/r/src/freifunk/tunneldigger/client/libasyncns/asyncns.c:23:
/home/r/src/freifunk/tunneldigger/client/libasyncns/asyncns.c: In function ‘asyncns_setuserdata’:
/home/r/src/freifunk/tunneldigger/client/libasyncns/asyncns.c:1484:12: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
     assert(q->asyncns = asyncns);
            ^
/home/r/src/freifunk/tunneldigger/client/libasyncns/asyncns.c: In function ‘asyncns_getuserdata’:
/home/r/src/freifunk/tunneldigger/client/libasyncns/asyncns.c:1492:12: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
     assert(q->asyncns = asyncns);
            ^

This needs further investigation to determine if the = should be ==.

[Felix Kaechele]

I contacted Lennart Poettering on October 27, 2019 but haven't heard back yet. This quite clearly looks like a typo.

[Alexander Couzens]

I've sent the patch to Lennart via mail.

[Ralf Jung]

Would be really good to hear back from Lennart about this -- or anyone else familiar with the asyncns code, actually.