offers two code actions even in JSON file

Question

offers two code actions even in JSON file

capaj opened this issue 6 years ago · comments

Jiri Spac commented 6 years ago

These two code actions should not be offered outside js/jsx/tsx:

Boris Litvinsky · Answer 1 · Sat Dec 22 2018 19:04:45 GMT+0800 (China Standard Time)

Hmmm. interesting. Should be an easy fix. Care for a PR? I can point you in the right direction :)

Jiri Spac · Answer 2 · Sun Dec 23 2018 18:56:04 GMT+0800 (China Standard Time)

for the JSON fix shoud be easy, but currently it suggests these two actions everywhere. Ideally it would only suggested them if a JSX code block is selected.

Boris Litvinsky · Answer 3 · Mon Dec 24 2018 16:23:53 GMT+0800 (China Standard Time)

@capaj As far as i can remember, it relies on babel to check if its a JSX string.
This is the place to start investigating: https://github.com/wix/vscode-glean/blob/master/src/extension.ts#L18

Jiri Spac · Answer 4 · Mon Dec 24 2018 16:40:44 GMT+0800 (China Standard Time)

I think this will always succeed: https://github.com/wix/vscode-glean/blob/da530190356a755d3703c80f96f7ab8509fb7e7b/src/modules/jsx.ts#L16

JSX doesn't really impose any restrictions as to what can be inserted inside {}. Any JS expression is valid so I think this would be better refactored into just checking if there is a JSX node inside the selection. Will try to whip up some alternative solution for isJSX over the next few days/weeks.