Wrap new component code with fragment only if needed

Question

Wrap new component code with fragment only if needed

chiptus opened this issue 6 years ago · comments

Thank you for this extension, for a long time I wanted one like this (I started creating one, but didn't have the time to make it more production ready).
Now for the bug/feature-request:

Not always I will need a fragment (<>) wrapping my new component. It should wrap only when there's more than one element in the root

Boris Litvinsky · Answer 1 · Wed Oct 31 2018 01:22:23 GMT+0800 (China Standard Time)

@chiptus Glad you liked it! Thank you! As for the idea - I agree completely!
The problem here is that Babel doesnt know how to parse multiline JSX, and throws an error. Thats why I wrap it by default.
The naive solution would be to have a try-catch statement, with a fallback in the catch statement. But that pretty bad.

Boris Litvinsky · Answer 2 · Wed Oct 31 2018 18:50:34 GMT+0800 (China Standard Time)

@chiptus i've created a naive implementation for now
24ff2b0
Check it out in v4.0.7

Chaim Lev-Ari · Answer 3 · Thu Nov 01 2018 01:51:06 GMT+0800 (China Standard Time)

I will check it out, thanks!

…

On Wed, Oct 31, 2018, 12:50 Boris Litvinsky ***@***.*** wrote: @chiptus <https://github.com/chiptus> i've created a naive implementation for now 24ff2b0 <24ff2b0> Check it out in v4.0.7 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUVF3Kei-og1ewRMF4cxUHXwIPg-XQjks5uqYB_gaJpZM4YCAaz> .