Support for mj-html-attributes, mj-selector, mj-html-attribute?

Question

philipwindeyer opened this issue 2 years ago · comments

Hello, is there a timeline on adding support for the newer mj-html-attributes, mj-selector, and mj-html-attribute head components?

Thanks in advance

Dalius Dobravolskas · Answer 1 · Fri Feb 18 2022 14:27:15 GMT+0800 (China Standard Time)

There is pull request #54 but it is conflicting with master. Wanna fix it?

Philip · Answer 2 · Fri Feb 18 2022 14:32:59 GMT+0800 (China Standard Time)

Saw that; although it's a year old and it's attempting to redefine MjmlAttributes as MjmlHtmlAttribute 😕.

I can dedicate time to this on Monday. Will open a new PR then if that works for you? @daliusd

Dalius Dobravolskas · Answer 3 · Fri Feb 18 2022 14:41:29 GMT+0800 (China Standard Time)

Yes, it works for me.

Philip · Answer 4 · Wed Feb 23 2022 12:35:04 GMT+0800 (China Standard Time)

Hey @daliusd, just opened #72 . Will update types in DefinitelyTyped shortly

Dalius Dobravolskas · Answer 5 · Wed Feb 23 2022 15:53:04 GMT+0800 (China Standard Time)

Hi @philipwindeyer we will review it.

Philip · Answer 6 · Mon Feb 28 2022 12:10:42 GMT+0800 (China Standard Time)

FYI: PR for accompanying typedefs, for the TypeScripters DefinitelyTyped/DefinitelyTyped#59026