The Windows build broke on windows-2022
joaodasilva opened this issue · comments
Joao da Silva commented
GitHub has updated "windows-latest" from "windows-2019" to "windows-2022":
The v8 build fails to start with that change:
Building v8 in libraries/v8/out/Release"
1 file(s) copied.
Traceback (most recent call last):
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 573, in <module>
sys.exit(main())
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 569, in main
return commands[sys.argv[1]](*sys.argv[2:])
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 546, in GetToolchainDir
runtime_dll_dirs = SetEnvironmentAndGetRuntimeDllDirs()
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 106, in SetEnvironmentAndGetRuntimeDllDirs
os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 197, in DetectVisualStudioPath
version_as_year = GetVisualStudioVersion()
File "D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py", line 186, in GetVisualStudioVersion
raise Exception('No supported Visual Studio can be found.'
Exception: No supported Visual Studio can be found. Supported versions are: 16.0 (2019), 15.0 (2017).
ERROR at //build/config/win/visual_studio_version.gni:27:7: Script returned non-zero exit code.
exec_script("../../vs_toolchain.py", [ "get_toolchain_dir" ], "scope")
^----------
Current dir: D:/a/windowjs/windowjs/libraries/v8/out/Release/
Command: D:/a/windowjs/windowjs/libraries/depot_tools/bootstrap-2@3_8_10_chromium_23_bin/python3/bin/python3.exe D:/a/windowjs/windowjs/libraries/v8/build/vs_toolchain.py get_toolchain_dir
Returned 1.
See //build/toolchain/win/BUILD.gn:9:1: whence it was imported.
import("//build/config/win/visual_studio_version.gni")
^----------------------------------------------------
See //BUILD.gn:1516:1: which caused the file to be included.
action("postmortem-metadata") {
^------------------------------
GN failed!
Joao da Silva commented
Seems like build.git needs to be updated:
https://chromium.googlesource.com/chromium/src/build/+/75d20d012b212b3fdf5b062ea2eafcafa22ba1a9
Joao da Silva commented
This might work now, after having updates all dependencies. Trying with 687f855.
Joao da Silva commented
This is working now: https://github.com/windowjs/windowjs/actions/runs/4336463748