The link in the Error Notification email leads to a login loop
hershagarwal opened this issue · comments
When I receive an error notification email from Windmill, the link provided (example) leads me to a Windmill login page, even if I'm already logged in. When I click login with Google, it shows as logging me in, then returns to the login page.
The link provided didn't create a loop for me. It might be that you are attempting to go to a workspace that you are not a member of, in which case, it will log you out, giving you the feeling of a loop.
Hi,
Please see this video: loom link
<https://www.loom.com/share/59cc37ef39454d97be91d1b078255cba?sid=3dea2794-56b3-4073-a14a-a3faa86e1106>
I click on the link and attempt to login multiple times, with it showing
the dashboard for a split second, then returning. I then open a new tab, go
directly to windmill.dev, and am able to login.
I know for sure that I am a member of this workspace, as I have never used
another account to create on Windmill.
Thanks,
Hersh
…On Wed, May 15, 2024 at 6:24 AM, Ruben Fiszel ***@***.***> wrote:
The link provided didn't create a loop for me. It might be that you are
attempting to go to a workspace that you are not a member of, in which
case, it will log you out, giving you the feeling of a loop.
—
Reply to this email directly, view it on GitHub
<#3726 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQPCW6PFKRZYK2C3WEDHRZTZCMZU7AVCNFSM6AAAAABHWJWDZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGEZTKOBVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
The issue is still happening. It logs in fine if I go to windmill.dev, but
the link from the error notification goes into that loop.
On Thu, May 16, 2024 at 1:13 AM, Hersh Agarwal ***@***.***>
wrote:
… Hi,
Please see this video: loom link
<https://www.loom.com/share/59cc37ef39454d97be91d1b078255cba?sid=3dea2794-56b3-4073-a14a-a3faa86e1106>
I click on the link and attempt to login multiple times, with it showing
the dashboard for a split second, then returning. I then open a new tab, go
directly to windmill.dev, and am able to login.
I know for sure that I am a member of this workspace, as I have never used
another account to create on Windmill.
Thanks,
Hersh
On Wed, May 15, 2024 at 6:24 AM, Ruben Fiszel ***@***.***>
wrote:
The link provided didn't create a loop for me. It might be that you are
attempting to go to a workspace that you are not a member of, in which
case, it will log you out, giving you the feeling of a loop.
—
Reply to this email directly, view it on GitHub
<#3726 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQPCW6PFKRZYK2C3WEDHRZTZCMZU7AVCNFSM6AAAAABHWJWDZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGEZTKOBVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Would you be able to share another link because the one you shared above is going to a wrong workspace (allaroundchildren), with an extra )
Hmm, I see that appears to be the cause of the issue, but I don't know
where that extra parenthesis is being introduced.
This is the link from my email:
Flow [018fca71-bf62-7e48-5f95-24e013afcc5f](
http://url650.allaroundchildren.com/ls/click?upn=u001.G5iEFUXFcmPSc-2FSTwSVsZVOgA7-2ByChgFFHjjmEEJTwm544MAPLiH25NCZOT9YZ-2B3RU5ECjOGwUCq4T2MRGjSviP7IN3ARA58vHRYH1PsIuMuU4pA90cAof-2BKXklWM0NpyqMG54n-2BEuqZMOMtY-2BqfAQ-3D-3DVGbx_NTML-2FbsxXLDaoAKPIMG-2BT9m0QM-2BxXw-2BW8LPp8rpeykTJ6wOJrEhwrnKG6LKA8c1uaaDhHJBKbA1IPqQBS3pIkU5E2cssDFziqq-2FOqsoz6WHwq5ow6K4EkHb3CLSWYyDJTEjvmg1nfq9Cn7wIjF7Q3LerC3uzy5G3VM2303lG3TgcI1Q1wq8eTXQytRn4kNAUmk54vUmfCYOtcCw2LWCS-2Fg-3D-3D
had an error: TypeError: 'bool' object is not subscriptable
This is the link after clicking on that:
https://app.windmill.dev/run/018fca71-bf62-7e48-5f95-24e013afcc5f?workspace=allaroundchildren
)
This is the Error Handler code:
import os
import requests
def main(message, name, sendgrid_api_key):
# Environment variables for flow details
flow_id = os.getenv("WM_FLOW_JOB_ID")
wm_base_url = os.getenv("WM_BASE_URL")
wm_workspace = os.getenv("WM_WORKSPACE")
# Construct the message
flow_url = f"{wm_base_url}/run/{flow_id}?workspace={wm_workspace}"
text = f"Flow [{flow_id}]({flow_url}) had an error:\n{name}: {message}"
# Setup email details
recipient_email = ***@***.***"
cc = ***@***.***"
sender_email = ***@***.***"
subject = "Windmill Error Notification: Hourly Time Card Alerts"
content = {
"type": "text/plain",
"value": text
}
# SendGrid Mail Send API endpoint and headers
url = "https://api.sendgrid.com/v3/mail/send"
headers = {
"Authorization": f"Bearer {sendgrid_api_key}",
"Content-Type": "application/json"
}
# Email data
data = {
"personalizations": [
{
"to": [{"email": recipient_email}],
"cc": [{"email": cc}]
}
],
"from": {"email": sender_email},
"subject": subject,
"content": [content]
}
# Send the email
response = requests.post(url, json=data, headers=headers)
# Check response status
if response.status_code == 202:
print("Email sent successfully.")
else:
print(f"Failed to send email. Status code: {response.status_code},
Response: {response.text}")
return {"message": text, "flow_id": flow_id}
…On Thu, May 30, 2024 at 3:28 PM, Ruben Fiszel ***@***.***> wrote:
Would you be able to share another link because the one you shared above
is going to a wrong workspace (allaroundchildren), with an extra )
—
Reply to this email directly, view it on GitHub
<#3726 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQPCW6KN7AQRQHGCVV727DTZE54U5AVCNFSM6AAAAABHWJWDZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQG4ZTENZYGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>