windmill-labs / windmill

Open-source developer platform to turn scripts into workflows and UIs. Fastest workflow engine (5x vs Airflow). Open-source alternative to Airplane and Retool.

Home Page:https://windmill.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug: Dangerous shareable page for deployment - 50:50 chance of deploying in wrong direction

wasnertobias opened this issue · comments

Describe the bug

"Shareable page
Share this link to have another properly permissioned user do the deployment"

This hint is dangerous as it does not link with the correct workspace. So the user who should deploy can either deploy from STAGING to PROD or from PROD to STAGING, depending on which workspace the user currently has selected. So it does essentially 50:50 overwrite any changes, which should be deployed.

To reproduce

  1. Go in deploy view of flow

Expected behavior

Make the link workspace-dependent with "?workspace=xyz"!

Screenshots

No response

Browser information

Chrome Version 124.0.6367.119

Application version

EE v1.323.6-9-g1795522d2

Additional Context

No response