windmill-labs / windmill

Open-source developer platform to turn scripts into workflows and UIs. Fastest workflow engine (5x vs Airflow). Open-source alternative to Airplane and Retool.

Home Page:https://windmill.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug: No permission to deploy from TEST to PROD, but no error

wasnertobias opened this issue · comments

Describe the bug

If a user does not have permission to deploy from TEST to PROD, it can still try to do so. Even get's a success message (green "deployed" badge), but it does not actually deploy anything!

To reproduce

Described above

Expected behavior

No success message if permission is not sufficient!

Screenshots

No response

Browser information

Chrome Version 124.0.6367.119

Application version

EE v1.323.6-9-g1795522d2

Additional Context

No response

More specifically, it does show a diff in the flow (a parameter of a sub-flow changed). After clicking "deploy all" it does show "Deployed" in green but it does not change anything.

The following endpoint gets called: "https://BASE_URL/api/w/PROD_NAME/flows/update/FLOW_NAME"
The endpoints payload does not include the change I made (shown in the diff).
It returns successfully with status 200 and the name of the flow.