win32ss / supermium

Chromium fork for Windows XP/2003 and up

Home Page:https://win32subsystem.live/supermium/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[UX, DARK MODE] `enable-force-dark` - where?! (flag name changed)

XakerTwo opened this issue · comments

long story short - the lack of feature presentation, sry for mis-issue

long both, the changelog and the commit, has no info about changing the names of the switch and the flag

now flag name is dark-mode-settings
and switch ... well, at my surprise no one of v100+ have it for web-content, and --force-dark-mode actually enable dark mode for web-ui. So there no simple on/off switch, however processes get this one

--dark-mode-settings=InversionAlgorithm=3,ImagePolicy=1,ForegroundBrightnessThreshold=150,BackgroundBrightnessThreshold=205

but seems like it can be shortened without visible consequences to --dark-mode-settings=InversionAlgorithm=3
the one "feature" of the --dark-mode-settings switch is that it keeping flag in orignal state (no sync with command line switches, even in full form), but assume it is an internal argument not supposed to be used by 🍌💣

how it's used can found here, but i keep some info under spoiler

short description

InversionAlgorithm - color inversion mode

  • 1 - RGB
  • 2 - HSL
  • 3 - CIELAB

ImagePolicy - how images inverted

  • 0 - officially not used, but i guess it disable images inversion completely
  • 1 - simple/dumb (but on first glance same as 2)
  • 2 - selective

*BrightnessThreshold-s is for fine tuning, you may try to play with it(i assume in range 0 .. 255) or keep default values(150 for Foreground and 205 for Background)

ImageClassifierPolicy - toggle of "color and transparency basis" for image selection (used in last mode from dropdown)

  • 0 - not used, i guess, equals to disabled
  • 1 - enabled

former selective everything ... modes actually was and still CIELAB-based
RGB shitty as always, HSL and color-based(that is also HSL-based) looks too blackish for me

anyway it should be noted in the changelog and in the description of the flag, e.g.
"... Supermium exclusive, replacement of #enable-force-dark"
probably the new name of the switch also should be mentioned in the description

Also --force-dark-mode did not work for now, but still exists and mentioned(instead of enable-force-dark) in README.md (main repo page)

i'm keep issue opened, but it can be closed as needed

original postwhile this is not really critical bug, it is critical for me, i never relying on end-site features it this question

Screenshots

image

image

image

Desktop (please complete the following information):

  • OS: Windows 7 SP1 x64
  • SM: 126.0.6478.254 R4 x64 (as is, no patches)

WHAT DID YOU NEED FROM ME TO FIX THIS ???!!! and what should i do to provide it?(switches, log locations, etc. )

for now i'm rolling back to R3

p.s. here a lot of misunderstood and confusions from my side, cuz i did not track related info and "stuck in v88" or older. plus i made a common mistake - updating just before go off with all consequences

image
^^^^^^^^

I would prefer using Dark Reader anyway since the flag breaks some sites and it's not possible to blacklist/whitelist a site (hmm... what if I open a feature request about it 😅 )

try 😄 in rare cases it will be useful
but mostly i like native CIELAB gray theme, and for such cases have StyleBot and :root { color-scheme: dark; }

and about title of the flag - i usually ignore it when know flag name/id, so did not expect such a trap + auto for me equals to something i can't control. i only notice this new flag with old title after digging in commit 🤣