Android hardware button quit widgetbook application
mjablecnik opened this issue · comments
Description
When I run Widgetbook in mobile device, I have a bottom panel with 3 icons (Navigation, Addons, Knobs).
When I click on one icon so modal popup is showed with content. For close this modal you can swipe it down or click outside.
But when you accidentally click on Hardware button in Android, whole application is closed.
Steps To Reproduce
- Start Widgetbook in Android mobile
- Click on Addons icon in bottom panel
- Click on hardware android button
- Whole application is closed
Expected Behavior
When is opened modal popup, close this popup.
When is not opened modal popup, show dialog with question if I really want to quit whole application.
Hello @mjablecnik 👋
As this issue might be a low-priority to us compared to other issues that affect web/desktop,
do you want to work on fix for this?
Hello ! I want to contribute to Widgetbook. Can I work on this issue ?
@YoussefRaafatNasry Now I do not have a time so @IvanGael if you want to work on this issue you can do it ;)
Okay good @YoussefRaafatNasry . I'll start to work on it soon.
I will get back to you if I have any questions.
Hello @YoussefRaafatNasry @mjablecnik ! I just submit a PR for this issue. Let me know your thoughts.
Here is a link : #1200