Blank space appears if app opened with sidebar closed
whyboris opened this issue · comments
👌 not a big bug, but could be nice to fix.
To replicate: close the sidebar, exit the app, reopen the app.
Hello, If this issue is still there, can i work on it?
Sorry was away to a conference - just got back to GitHub 😅
Thank you for the offer! Please feel free to give it a go. Let me know if you have any trouble along the way - I can help answer questions 🤝
@whyboris Hi! I was checking out this issue and tried to recreate it on demo 3.1.0
I did not notice a difference in behavior when the app is reopened with the sidebar open or closed. I am wondering if this issue was fixed in some previous PR?
Hey @joshHuang02 - thank you for checking up on that!
The codebase has moved on since the 3.1.0 release quite a bit, so there may be different bugs currently than in the demo (hopefully with some bugs already fixed).
It's possible that with the Angular update (merged last month) the initial bug is gone (I don't remember exactly what it was), but there's currently something a little off:
this doesn't affect filmstrip view, but affects the thumbnails view 🤔
If you replicate the action described above, when you re-open the application with the sidebar closed, the image sizes in the gallery are smaller than needed to fill up the full-width of the gallery space, resulting in empty space on the right.
This is super-unimportant, but I added the issue because someone emailed me and I thought it's probably easy to fix with a simple call to recalculate width after starting the app ... somewhere 
I'm sadly 😢 still working on some other projects before I return to VHA coding (hoping for mid-winter). But I'll be around to answer questions and help out if you're doing anything 🤝
@whyboris Hello,
Can I work on this issue?
Thank you @Adityamaurya123uma - this issue is still open - please take a look and see if you can fix it 🤝