whr94621 / NJUNMT-pytorch

Line 13 in b598413

--target_dict_path "/home/weihr/NMT_DATA_PY3/1.34M/dict/dict.en.json" \

Line 15 in b598413

--config_path "./configs.yaml" \

It seams to be of not necessity to provide src and tgt dicts since config.yaml has been provided.

Ooh ! That's indeed not necessary. Please send a PR to fix this. :)

This issue relates to translate.py

and src/main.py

Line 616 in b598413

    
           vocab_src = Vocab(dict_path=FLAGS.source_dict_path, max_n_words=data_configs['n_words'][0])

@zhengzx-nlp
这个细节，只要允许额外的--target_dict_path覆盖config_path里的参数就好了，就跟你run一个控制台的命令，command后面的参数总能生效是一样的道理。

Redundant config？