Giters

whisperfish / libsignal-protocol-rs

A Rust interface to the Signal Protocol. DEPRECATED in favour of https://github.com/signalapp/libsignal-client ! Signal reimplemented the whole thing in Rust.

Home Page:https://michael-f-bryan.github.io/libsignal-protocol-rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Addresses are a foot-gun

Michael-F-Bryan opened this issue · comments

commented

At the moment, we've got an Address<'a> type which is (effectively) a (&'a str, i32) tuple. The problem is a couple types contain a *const sys::signal_address and because our "safe" wrappers aren't constrained by the lifetime of the address, it's possible to have a dangling pointer when the original borrowed address is destroyed...