wharfkit / session

Create account-based sessions, perform transactions, and allow users to login using Antelope-based blockchains.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Create a test passing in an ESR payload w/ meta data and ensure metadata persists

aaroncox opened this issue · comments

I'm not sure if when you pass in an ESR payload, that the metadata will persist. The createRequest method takes the request body and creates a new SigningRequest object with it, which may disregard all the old information it contained.

https://github.com/wharfkit/session/blob/dev/src/session.ts#L291-L321

A test should be added that passes a request with metadata, and then ensures the metadata makes it through the entire process.

If it doesn't, then perhaps we need to clone the request instead of creating a new one?