wet-boew / wet-boew

Web Experience Toolkit (WET): Open source code library for building innovative websites that are accessible, usable, interoperable, mobile-friendly and multilingual. This collaborative open source project is led by the Government of Canada.

Home Page:https://wet-boew.github.io/wet-boew/index-en.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Datatables.net - header tooltip when sorting is disabled

DBlaisAsc opened this issue · comments

Hi

On a datatables.net grid, I disable sort on some columns, but the tooltip generated by the wet still add " : activate for ascending sort" to the column header tooltip. This give a strange behavior.

Regards

Can you provide a code sample such as some html and js your using?

I am just a volunteer on this GitHub project.

Hi

You can reproduce the issue with that simple example :

<section>
    <div class="table-responsive">
        <table id="SearchGrid" class="wb-tables table table-striped">
            <thead>
                <tr>
                    <th><i class="fas fa-folder"></i><span class="wb-inv">Detail</span></th>
                    <th><i class="fas fa-th-list"></i><span class="wb-inv">Saved list</span></th>
                    <th>Description</th>
                </tr>
            </thead>
        </table>
    </div>
</section>

<script type="text/javascript">

    window["wb-tables"] = {
        dom: "iltrp",
        columns: [
            {
                orderable: false,
                defaultContent: ""
            },
            {
                defaultContent: "",
                orderable: false
            },
            {
                name: "Description",
                data: "Description"
            }
        ],
        data: [
            { Description: "line1" },
            { Description: "line2" }
        ],
        order: [[2, 'asc']]
    };
</script>

What version of WET are you using?
Works fine in v4.0.56 -> v4.0.61.1

I cannot test in v4.0.63 as my build environment broke .

I use CDTS v4.0.47, that come with WET v4.0.56.5.

Ok, I had it patched in my development versions, that is why it worked for me.
The fix is this commit: Plugin Tables: Do not create sort/order button when column sort is disabled

This was merged into WET Release Release v4.0.62.

Thanks!