welovedevs / react-ultimate-resume

💼 🎨 A modern software developer resume built with React and JSONResume

Home Page:https://welovedevs.com/react-ultimate-resume

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Homepage doesn't display properly when serving production build locally

sheriffyusuf opened this issue · comments

It displays properly only when running with development build. Attached below is screenshot of production build served locally.

Screenshot from 2020-10-31 15-49-06

i'm having the same issue here. using node v12.10 to build & serve

Hi,

We've gone back and forth with Material UI and JSS providers.
We have two injection points in the index.html

      <!-- mui-insertion-point -->

        <!-- jss-insertion-point -->

They ensure the CSS is injected in the right point.

These comments are deleted by react-scripts in production mode, breaking the css injection order (cf facebook/create-react-app#4245) , i'm trying to work around this.
Sorry about that !

It's fixed on develop :)

Have a nice day :)

@clementdevos the fix to this seems to have been deleted ff38f98

Had the same issue but adding the block fixes it. 983ee00#diff-ec767e14d91498b5b31a4ce826c4596061eb83a47d3dee00f6cbe1078232a75c

Jeez i work on this alone and i managed to break it alone.

Will fix it asap.

There, i've added it back to develop. So sorry about this.