does upgrade 1.9 of vscode broke the plugin

Question

does upgrade 1.9 of vscode broke the plugin

ccinv opened this issue 7 years ago · comments

Hi.
Today I upgrade Astyle to 2.06 and vscode to 1.9.And evidently either of them broke the formatter.Then I switch astyle to old 2.05,the problem is still.
Issue:

Chieh Yu · Answer 1 · Tue Feb 07 2017 09:28:12 GMT+0800 (China Standard Time)

It seems somethings changed in vscode 1.9. I'm looking for the problem now.

Yanghe Sun · Answer 2 · Mon Feb 13 2017 19:33:43 GMT+0800 (China Standard Time)

vscode 1.9.1 fixed this

Oldnice · Answer 3 · Mon Apr 24 2017 15:46:30 GMT+0800 (China Standard Time)

I have the same problem with VSCode 1.9.1 and astyle 3. An empty lined is added to every other line in the file. This gets repeated every time formatting is invoked.

Edit: I had the same problem with VSCode 1.8.x, which made me upgrade my VSCode to 1.9.1, but it didn't fix the problem. Using older (2.x) version of astyle makes no difference either.

Sharif Tariq · Answer 4 · Thu Jun 01 2017 12:44:45 GMT+0800 (China Standard Time)

The problem still exists, and it seems to be related to files with LF line endings, at least on Windows. CRLF works fine. Tested using VS Code 1.12.2 and AStyle 3 on a Windows 10 machine.

Chieh Yu · Answer 5 · Tue Jun 06 2017 23:36:17 GMT+0800 (China Standard Time)

Hi @strike-zero,

Can you try add line ending options in astylerc?

--lineend=windows OR -z1
--lineend=linux OR -z2
--lineend=macold OR -z3
Force use of the specified line end style. Valid options
are windows (CRLF), linux (LF), and macold (CR).

thanks

Sharif Tariq · Answer 6 · Tue Jun 06 2017 23:55:21 GMT+0800 (China Standard Time)

@welkineins
I tried with all of the line ending options with the same results. Unless you change the end of line sequence from LF to CRLF in VS Code itself, the bug will occur.

Also one thing to note from the AStyle docs:
"When redirection is used on Windows the output will always have Windows line ends. This option (referring to line ending options) will be ignored."

Yanghe Sun · Answer 7 · Fri Jun 09 2017 19:12:31 GMT+0800 (China Standard Time)

Seems need to be reopen?

Ben · Answer 8 · Wed Jun 21 2017 16:01:12 GMT+0800 (China Standard Time)

I have the same problem

Environment	version
Visual Studio Code version	1.13.1
Astyle extension version	0.6.2
Astyle binary	3.0.1
Windows OS	Win10 x64

Chieh Yu · Answer 9 · Sat Jul 01 2017 13:11:57 GMT+0800 (China Standard Time)

Hi guys,

I finally have time to update the way to handle newline issue. Please help me to test if it's fix on 0.7.0. Hopes it does!

Thanks.

Sharif Tariq · Answer 10 · Sat Jul 01 2017 13:29:25 GMT+0800 (China Standard Time)

I gave it a quick test, and unfortunately it's still not fixed. I have also tried with all the line ending options.

Chieh Yu · Answer 11 · Sat Jul 01 2017 19:01:59 GMT+0800 (China Standard Time)

Hi @strike-zero,

Thanks with the quick test. But sorry I didn't fix it in 0.7.0.
I take other steps trying to fix the issue in 0.7.1.

Can you help to run the test again?

Thanks

Sharif Tariq · Answer 12 · Sun Jul 02 2017 10:49:37 GMT+0800 (China Standard Time)

Happy to report that the issue is finally fixed!
Thank you for the quick update.