Weld Serialize/Deserialize

Question

Weld Serialize/Deserialize

Max-Meldrum opened this issue 5 years ago · comments

I am using Weld's serialize(data) and deserialize[T](data) in a project. As most other libraries handle bytes as Vec<u8>, I am currently having to cast between i8/u8 while going from Weld to other libraries (e.g., RocksDB, Protobuf) and vice versa. Is there a motivation behind the choice of Vec<i8>?

I could look into creating a PR for this. Or if it would be breaking other projects relying on the current implementation, I could work on a fork instead.

Cheers

Shoumik Palkar · Answer 1 · Fri May 03 2019 21:56:03 GMT+0800 (China Standard Time)

Hi Max, You can submit a PR for this if you’d like — I think u8 makes more sense too and I don’t think it’ll break anything else. Shoumik

On Fri, May 3, 2019 at 4:56 AM Max Meldrum ***@***.***> wrote: I am using Weld's serialize(data) and deserialize[T](data) in a project. As most other libraries handle bytes as Vec<u8>, I am currently having to cast between i8/u8 while going from Weld to other libraries (e.g., RocksDB, Protobuf) and vice versa. Is there a motivation behind the choice of Vec<i8>? I could look into creating a PR for this. Or if it would be breaking other projects relying on the current implementation, I could work on a fork instead. Cheers — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#446>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKMEY3MVHD4LFGXD353JILPTP44PANCNFSM4HKSHVOA> .

-- Shoumik