Giters

weiquu / pe

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Conditions should be in brackets (Activity Diagram)

weiquu opened this issue · comments

commented

As title, e.g. should be [else] instead of else, [hasMember] instead of hasMember:

Screenshot 2021-11-12 at 5.35.20 PM.png

commented

Team's Response

I acknowledge this error in the diagram however, I feel that it does not take away from the reader's understanding of the diagram.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: The reader might still understand the diagram, yet the DG is written for developers and should follow the UML diagram rules (that have been set out in the CS2103 website). Since this diagram does not follow those rules and thus is incorrect, I would argue that it is not "purely cosmetic" and hence should be accorded the Low severity.