PR not merging, days after passing checks

Question

PR not merging, days after passing checks

liyishuai opened this issue 3 months ago · comments

Yishuai Li commented 3 months ago

Scenario: liyishuai/RSSHub#211

Expectation: Merge pull request after successful checks.

Observation: PR remains open.

Yishuai Li · Answer 1 · Thu Mar 07 2024 16:29:31 GMT+0800 (China Standard Time)

And merged after manually approving... Maybe worth documenting it somewhere?

Wei He · Answer 2 · Thu Mar 07 2024 19:28:18 GMT+0800 (China Standard Time)

Hello, thanks for opening the issue. Did you set up branch protection rules to require a approve before merging PRs to the branch?

Yishuai Li · Answer 3 · Fri Mar 08 2024 01:14:34 GMT+0800 (China Standard Time)

No branch protection rules. liyishuai/RSSHub#210 and liyishuai/RSSHub#212 were merged without my interference.

Wei He · Answer 4 · Fri Mar 08 2024 06:41:10 GMT+0800 (China Standard Time)

When there is a huge number of changes, GitHub takes a while to calculate the mergability of the PR. Pull bot will wait a bit but will give up and retry after a few hours if GitHub takes too long. Hope it helps!