number in vote app to big for styling
skipjack opened this issue · comments
From @sokra on February 20, 2017 10:49
maybe we can go with 112k and 67k if the number is higher than 1k
From @Dajust on February 20, 2017 19:28
I think that would make the voting not transparent enough, which I think is the main purpose of voting.
This may be addressed by #7 as well. There's certainly more room for the score in the new design.
maybe we can go with 112k and 67k if the number is higher than 1k
@sokra I had the exact same initial thought but I see @Dajust's point as well. If you're only putting +1 votes in you'd likely never even see the score change. We could at least format it a little better, e.g. with commas, and maybe shrink the number if it gets to be too large? Unless someone has another idea?
Ok this is definitely resolved by #7. Edited the content in the DOM and even with commas the score can easily go past the billions (which I think is plenty):
I'll update the PR so this is auto-closed once merged. I'll test again in the mobile view as well.