Use latest 2.23.0: TypeError: Cannot read property 'name' of undefined

Question

Use latest 2.23.0: TypeError: Cannot read property 'name' of undefined

hubcarl opened this issue 6 years ago · comments

sky commented 6 years ago

Operating System: Mac
Node Version: 8.9.1
NPM Version: 6.3.0
webpack Version: 4.17.1
${package} Version:

Expected Behavior

Actual Behavior

Use latest 2.23.0 version error, Use 2.22.0 version can run normally

How Do We Reproduce?

git clone https://github.com/hubcarl/egg-vue-webpack-boilerplate.git
yarn install
npm run dev

Glen Mailer · Answer 1 · Mon Sep 03 2018 17:44:13 GMT+0800 (China Standard Time)

@okcoker this looks to be caused by the recent update, any ideas?

Glen Mailer · Answer 2 · Mon Sep 03 2018 19:32:13 GMT+0800 (China Standard Time)

I've published a naive fix as v2.23.1 - keeping track of webpack's stats object across versions and configurations is always a pain.

Zlatko Fedor · Answer 3 · Tue Sep 04 2018 03:11:44 GMT+0800 (China Standard Time)

it is not working

Glen Mailer · Answer 4 · Tue Sep 04 2018 03:35:13 GMT+0800 (China Standard Time)

Are you getting the same error?

Zlatko Fedor · Answer 5 · Tue Sep 04 2018 03:36:30 GMT+0800 (China Standard Time)

Router.js:37 Uncaught (in promise) TypeError: Cannot read property 'router' of undefined
    at ProxyComponent.getChildContext (Router.js:37)
    at ProxyComponent.getChildContext (react-hot-loader.development.js:580)
    at react-tree-walker.js:204
    at new Promise (<anonymous>)
    at recursive (react-tree-walker.js:135)
    at react-tree-walker.js:153

I updated deps and started to see this error.

Glen Mailer · Answer 6 · Tue Sep 04 2018 03:43:15 GMT+0800 (China Standard Time)

That stack trace doesn’t seem to have anything to do with this module.

Zlatko Fedor · Answer 7 · Tue Sep 04 2018 03:43:56 GMT+0800 (China Standard Time)

I will let you know soon. I am trying to fix it somehow

sky · Answer 8 · Tue Sep 04 2018 09:55:28 GMT+0800 (China Standard Time)

https://github.com/hubcarl/egg-vue-webpack-boilerplate.git: It is working with 2.23.1. @glenjamin

Sean Coker · Answer 9 · Tue Sep 04 2018 14:15:41 GMT+0800 (China Standard Time)

@glenjamin your change is probably the exact change I would have made. Thanks for that.

My blind guess is it might have to do something with the stats object of a single vs multi compiler setup?

Glen Mailer · Answer 10 · Tue Sep 04 2018 17:00:35 GMT+0800 (China Standard Time)

That compilation object doesn’t seem to be documented. How did you find it in the first place?

Zlatko Fedor · Answer 11 · Tue Sep 04 2018 20:01:27 GMT+0800 (China Standard Time)

it was related to another package. you can close it. thanks

Sean Coker · Answer 12 · Wed Sep 05 2018 00:22:55 GMT+0800 (China Standard Time)

@glenjamin I just found it myself. I noticed name stats name wasn't being output but I had access to a compilation object with a name on it. I figured it was a small change to get more context about what was updated 🙈

There's documentation on it though. You can even hook into it.

https://webpack.js.org/api/plugins/

Every step of the way, the plugin will have full access to the compiler and, when applicable, the current compilation.