No hot reloading when there are warnings

Question

No hot reloading when there are warnings

mhgamework opened this issue 6 years ago · comments

I dont get hot reloading when there are warnings. I found a change in the client.js which, if i understand correctly, skips updating modules when there are warnings.

Before this commit this was not the case:
47a1932#diff-215b25d5bf5c0b4623ad1a2b62456f60

Is there a configuration i am missing or is this a regression?

Glen Mailer · Answer 1 · Fri Apr 13 2018 00:22:34 GMT+0800 (China Standard Time)

This is an unintended regression introduced by #275

I'm going to mark the new version as deprecated for now, until a fix is done.

Michiel Huygen · Answer 2 · Fri Apr 13 2018 04:04:37 GMT+0800 (China Standard Time)

Thanks! Should i revert to another version then? For now i managed to remove the warning but im guessing this might pop up again.

Glen Mailer · Answer 3 · Fri Apr 13 2018 06:03:43 GMT+0800 (China Standard Time)

Yep, reverting is your best bet for the moment

Glen Mailer · Answer 4 · Fri Apr 13 2018 14:20:04 GMT+0800 (China Standard Time)

I've just pushed a fix into master, would you mind giving the prereleased code a go to verify the fix is correct @mhgamework ?

Glen Mailer · Answer 5 · Wed Apr 18 2018 15:39:02 GMT+0800 (China Standard Time)

Ok, I'm going to go ahead and release this fix as v2.22.1