False positive warning about Webpack 2

Question

False positive warning about Webpack 2

gaearon opened this issue 7 years ago · comments

We are seeing this warning on CI trying to update Create React App to Webpack 3: facebook/create-react-app#2574 (comment). However we never explicitly use json-loader.

I wonder if it's possible that the warning has a false positive? For example webpack/webpack#3374 makes webpack delegate to json-loader automatically here. Is there any chance that this could unintentionally trigger the warning?

Alberto Saavedra commented 7 years ago

+1

dan commented 7 years ago

Thanks!

Scot Matson · Answer 1 · Sun Jul 23 2017 03:37:21 GMT+0800 (China Standard Time)

I noticed this issue when I have placed some dependencies for package.json under devDependencies. I have since moved everything back under dev and the warnings no longer occur.

Joshua Wiens · Answer 2 · Sun Jul 23 2017 04:02:45 GMT+0800 (China Standard Time)

@gaearon - I've stripped the deprecation warning entirely, this is a problem that needs to be fixed upstream as the whole thing is kind of circular.

json-loader@0.5.7

Vinc' · Answer 3 · Mon Jul 24 2017 01:05:09 GMT+0800 (China Standard Time)

Thank you @d3viant0ne ! With the "json-loader": "^0.5.7" in the package.json, we get rid of thoses "useless" warning messages ! 🥇