webpack-contrib / json-loader

json loader module for webpack - UNMAINTAINED

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use inputValues as shortcut?

jhnns opened this issue · comments

I'm not sure if I understand the docs correctly, but shouldn't the json-loader try to read from inputValues first?

I'm using @okonet's yaml-loader which returns the parsed yaml as json string. After that the json-loader re-parses the string which is unnecessary.

It's probably unnecessary to use json-loader in addition to yaml-loader since the output is pretty the same. I could adjust yaml-loader to return the native object. This will eliminate an additional parse and the plugin should be then listed in basic section. WYT @sokra?

@jhnns Yes we can do this.

@jhnns @okonet Is this still relevant somehow? 👀 Or can we close this 😛 ?

@michael-ciniawsky it doesn't look like I've updated the yaml-loader. Please feel free to submit a PR or I could transfer the loader to webpack-contrib org if this is more desirable.

We deprecated the inputValues property, so this can be closed.

@okonet Regarding the yaml-loader: It would be nice if the yaml-loader would just generate an object and pass it on. The json-loader can handle inputs that are no strings.

I think, transferring the yaml-loader to webpack-contrib makes sense since yaml is a popular file format 👍

Hmm, @jhnns I got this then attempted to transfer it:

You don’t have the permission to create repositories on webpack-contrib

Can someone add me?

Can someone add me?

cc @bebraw @d3viant0ne

I think @d3viant0ne can comment on the proper process. We've done it before with mixed results.