`all*` methods are actually impure
BackEndTea opened this issue · comments
Gert de Pagter commented
Ran into this while seeing if we could use psalm to check the code base itself.
So the question is, should we mark them as impure?
ERROR: ImpureMethodCall - src/Mixin.php:3210:9 - Cannot call a possibly-mutating Traversable::getIterator from a pure context (see https://psalm.dev/203)
foreach ($array as $entry) {
static::isNonEmptyMap($entry, $message);
}