webbedfeet / python-intermediate-inflammation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Enhancement] Coding Conventions Inconsistencies

macieslik opened this issue · comments

Blank Lines

Top-level function and class definitions should be surrounded with two blank lines.

Example of inconsistency in models.py (lines 12-25):

image

Consider using blank lines to indicate logical sections.

Example of inconsistency in models.py (lines 50-56) (separated try-expect blocks):

image

Try to use consistent formatting for similar blocks.

Example of inconsistency in test_patient.py (lines 4-16):

image

Docstrings

Docstrings at the beginning of modules, classes and functions with are recommended.

Example of inconsistency in test_models.py (lines 42-50):

image

Whitespaces

Assignments should be surrounded with a single space on both sides.

Example of inconsistency in models.py (lines 27-30):

image

Single whitespace should follow immediately after a comma.

Example of inconsistency in test_patient.py (lines 18-27):

image

There should be no whitespaces around keyword argument assignment.

Example of inconsistency in test_models.py (lines 42-50):

image

Redundant Code

Unused dependencies should be removed.

Example of inconsistency in views.py (line 4):

image