[Modal]: add z-index prop to modal

Question

[Modal]: add z-index prop to modal

AbhinavMV opened this issue 2 years ago · comments

Abhinav MV commented 2 years ago

slfweb · Answer 1 · Fri Dec 23 2022 04:48:24 GMT+0800 (China Standard Time)

Interested to work on this one. Can you give more context, please?

Abhinav MV · Answer 2 · Fri Dec 23 2022 14:58:32 GMT+0800 (China Standard Time)

Hey @SebastianLF, Great to hear that you are interested to work on this 🤩

Context:
The modal component has hardcoded z-index right now. I was thinking of adding a new prop to the component called -> zIndex . And based on this value the modal will get a z-index. Also whatever value is used right now should be the default value. so that there are no breaking changes 😄

I will assign you this issue. Let me know if you want any help, btw you can join moralis discord channel and ask for any help in web3uikit channel 🙌🏻

slfweb · Answer 3 · Fri Dec 23 2022 20:58:40 GMT+0800 (China Standard Time)

Thanks for this clear explanation. Let's try it!

Abhinav MV · Answer 4 · Thu Dec 29 2022 14:47:27 GMT+0800 (China Standard Time)

Hey @SebastianLF 👋🏻
How is this task going?
Let me know if you are facing any issues 🙌🏻

slfweb · Answer 5 · Thu Dec 29 2022 23:52:47 GMT+0800 (China Standard Time)

Sorry, will work today on it :)

Abhinav MV · Answer 6 · Mon Jan 02 2023 13:02:58 GMT+0800 (China Standard Time)

Nice work @SebastianLF 🥳

Closed as completed by #981