Remove saved.keymap from ece.js

Question

Remove saved.keymap from ece.js

aliams opened this issue 6 years ago · comments

I noticed that https://github.com/web-push-libs/encrypted-content-encoding/blob/master/nodejs/ece.js#L264 still uses "saved" even though it's been removed.

aliams · Answer 1 · Thu Jan 11 2018 08:55:59 GMT+0800 (China Standard Time)

cc @martinthomson

Martin Thomson · Answer 2 · Thu Jan 11 2018 09:01:00 GMT+0800 (China Standard Time)

@aliams, yeah, that's a simple bug. Do you think that you could create a PR?

aliams · Answer 3 · Thu Jan 11 2018 09:03:25 GMT+0800 (China Standard Time)

I just filed this pull request: #46. I hope just removing it was what was intended.

Martin Thomson · Answer 4 · Fri Jan 12 2018 14:22:01 GMT+0800 (China Standard Time)

I think that will do for now. There are probably some other cleanups that would make things slightly better, but this gets rid of the glaring undefined reference problem.