Parse base64 encoded values with padding '=' characters cause error

Question

Parse base64 encoded values with padding '=' characters cause error

commandus opened this issue 6 years ago · comments

Andrei Ivanov commented 6 years ago

Some services like Google's MCS using padding, e.g.

encryption: salt=3jFrNEVgtPynKcHPmHXawA==

ece_webpush_aesgcm_headers_extract_params() return -13 error in this case.

Deleted user · Answer 1 · Sun May 06 2018 03:33:27 GMT+0800 (China Standard Time)

Thanks, @commandus! This should be fixed in 8197205, I'll merge it as soon as Travis is green.

In general, it's not a good idea for servers to send padding, since it's omitted in RFC 7515, and other implementations might reject it. But we can at least make ecec more forgiving, and working code is always better than following a spec to the letter! 😸

Andrei Ivanov · Answer 2 · Sun May 06 2018 09:08:30 GMT+0800 (China Standard Time)

Ok, thanks! вс, 6 мая 2018 г., 4:33 Kit Cambridge <notifications@github.com>:

…

Thanks, @commandus <https://github.com/commandus>! This should be fixed in 8197205 <8197205>, I'll merge it as soon as Travis is green. In general, it's not a good idea for servers to send padding, since it's omitted in RFC 7515, and other implementations might reject it. But we can at least make ecec more forgiving, and working code is always better than following a spec to the letter! 😸 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACY3tI3GmSt2FmezRHj-Yhp2GRuhk6hAks5tvf6HgaJpZM4Tx-eW> .