Giters

weavejester / ring-oauth2

OAuth 2.0 client middleware for Ring

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is the example `ring-defaults` missing the actual handler in README.md?

yatesco opened this issue · comments

commented

Hiya - I might be being dumb, but in README.md it states:

(wrap-defaults (-> site-defaults (assoc-in [:session :cookie-attrs :same-site] :lax)))

Isn't this missing the actual handler itself as the first parameter to wrap-defaults:

(wrap-defaults YOUR-ACTUAL-HANDLER (-> site-defaults (assoc-in [:session :cookie-attrs :same-site] :lax)))

(I realise this is probably used with (-> YOUR-ACTUAL-HANDLER (wrap-defaults (-> .... but it tripped me up :-))

Happy to do a PR with updated doc?

commented

Yes, that's an error, thank you for pointing that out. A PR would be welcome, though use handler rather than YOUR-ACTUAL-HANDLER.