wearefine / rails-jenkins-shared-libraries

Test and deploy your Rails application with Jenkins piplines

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Malformed Docker Registry URL fails silently

cpitkin opened this issue · comments

Issue summary:
Malformed by leaving out the //
DOCKER_REGISTRY_URL = 'https:335883679137.dkr.ecr.us-west-2.amazonaws.com/wearefine/base_ruby'

Code:
The error occurs on this line: https://github.com/wearefine/rails-jenkins-shared-libraries/blob/master/vars/railsDocker.groovy#L31

Proposed fix:
Check that the URL has the correct format when checking for the presence of the value