Implement FSWATCHER_PATH_ENCODING_***

Question

Implement FSWATCHER_PATH_ENCODING_***

wc-duck opened this issue 9 years ago · comments

Fredrik Kihlander commented 9 years ago

Macro currently do nothing!

yanglinjie8823857 · Answer 1 · Fri Dec 06 2019 18:45:14 GMT+0800 (China Standard Time)

just do it！

Fredrik Kihlander · Answer 2 · Fri Dec 06 2019 19:00:15 GMT+0800 (China Standard Time)

I'm open for pullrequests as I currently do not have that much time between work and family with small kids.

Fredrik Kihlander · Answer 3 · Wed Jun 09 2021 00:46:19 GMT+0800 (China Standard Time)

I have decided against this as it just makes the api harder to read and write + the potential define-mismatch issue in code using fswatcher. Also, me being an utf8 everywhere kind of guy would suggest just converting encoding at the border where you are talking to the system-api:s, read WinAPI.
Please re-open if any one have a good reason to do this anyways... im no worse than that I can change my mind ;)