Giters

wbond / pybars3

Handlebars.js template support for Python 3 and 2

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Travis CI Config for Python 3

wbond opened this issue · comments

commented

The whole point of this library versus pybars is to support Python 3. The Travis CI config should probably run this on at least Python 3.3 and 2.7 because of that.

commented

Absolutely... I tried to build pybars3 with different python versions, and there are several different issues. Here is a link to my build: https://travis-ci.org/maxkoryukov/pybars3/builds/184107757

flake8

./pybars/_compiler.py:185:25: F821 undefined name 'unicode'
./pybars/_compiler.py:271:16: F821 undefined name 'unicode'
2     F821 undefined name 'unicode'

tests / coverage

The code doesn't pass all tests, in most cases I got:

AttributeError: 'PybarsError' object has no attribute 'message'
commented

FYI: I have a branch for this issue, I think, I could fix this on this week

commented

Rather than e.message you should be casting the error to str.

commented

it is your test code ;))

anyway: e.message => str(e) DONE

  • python 2.6 - fucked up.. users with python 2.6 should upgrade their soft
  • python 3.2 - doesn't know what to do with u'some string'. I think, we could drop this version too;)