wasmerio / webassembly.sh

Open-source and installable PWA terminal powered by WebAssembly, WAPM, and Wasmer-JS 🖥

Home Page:https://webassembly.sh

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support Asian Scripts

jayadevanraja opened this issue · comments

When I type

echo Hello World

that is displayed perfectly. But Asian (Malayalam) text - which the browser supports - is not getting rendered properly.

echo ജയദേവൻ
echo-01

This happens in both Firefox and Chrome.

@Jayadevan-Vijayan

Hello! Thank you for the issue! 😄

I'll look into this, I think it may be involved with an issue with Xterm.js, so I'll do a quick investigation there.

Thanks again for finding this! 👍

So please excuse my context on this.

So the characters should look something like: https://en.wikipedia.org/wiki/Malayalam .

But it appears they are being squished together correct? Like they don't have the right spacing?

I think this may be related to: xtermjs/xterm.js#1709 if so.

Let me know if am I understanding this correctly @Jayadevan-Vijayan 😄 Thank you!

Yes. That is true.

But some Asian scripts do render correctly. Also some European scripts may not be perfectly rendered. I feel that ẞß (in German) is not perfectly rendered, though quite readable.

echo-02

I tried entering this:
മലയാളം ಕನ್ನಡ বাংলা ଓଡ଼ିଆ తెలుగు தமிழ் සිංහල ÄäÖöÜüẞß

@Jayadevan-Vijayan

Thank you for clarifying! 😄

Once I get the chance, I'll look into other issues mentioned on: xtermjs/xterm.js#1709 And try to fix this downstream 👍

So this seems to work in Hyper:

Screen Shot 2020-01-22 at 3 28 46 PM

And to my understanding, they use the xterm-addon-ligatures, which fixes the way the fonts are rendered. However, I linked to the requirements, and this addon needs system access to use the native font renderer. So we are going to half to figure out how to implement this in the browser 🤔

In the meantime, going to close this issue, and move it into: wasmerio/wasmer-js#185