walmartlabs / hula-hoop

Server-side rendering components for Thorax + Hapi stacks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

installed as a sibling of hula-hoops

sberryman opened this issue · comments

What in the world does this mean in the README.md?

Note that using this task requires that lumbar be installed as a sibling of hula-hoops at build time. Any arguments passed in the options field will be forwarded to the lumbar constructor, allowing for plugins and libraries to be specified.

I'm having a problem starting the latest seed of thorax.

Cmd: node ./node_modules/grunt-cli/bin/grunt --verbose

Fails:

Running "hapi-routes:map" (hapi-routes) task
Verifying property hapi-routes.map exists in config...OK
File: [no files]
Options: config="./lumbar.json", package="web", dest="./build/module-map.json"
Fatal error: Cannot read property 'modules' of undefined

I'm assuming this means lumbar.json is not present: node_modules/hula-hoop/lumbar.json

I'm posting here because I saw that quote above in the readme and I had a feeling that was important.

Can you send over your npm ls please and the exact hapi-route config in your gruntfile?

So I'm traveling right now and I don't remember seeing entities missing from lumbar > cheerio but here is what you requested:

npm ls and hapi-route:
https://gist.github.com/sberryman/e06faa7f8d6eb54a35cb

This was just a clone of walmartlabs/thorax-seed and running npm install followed by npm start

FYI, changing the entities version in lumbar > cheerio to * just for testing didn't make a difference. It still fails with the same error.

I believe this is fixed with the latest lumbar and hula-hoop. I've updated the thorax-seed package to load these. Please let me know if updating to the latest there does not resolve the issue.

Great news! I just cloned the seed again and everything is starting up properly! Thanks for getting this fixed, I'm looking forward to trying out thorax this weekend.