waku-org / js-waku

JavaScript implementation of Waku v2

Home Page:https://js.waku.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

chore: fail when both pubsubTopics and shardInfo are specified

vpavlin opened this issue · comments

This is a change request

Problem

When setting up light node, users can specify both pubsubTopics and shardInfo which seems to result in unwanted behaviour

Proposed Solutions

Error out when both pubsubTopics and shardInfo are specified and suggest only one is provided

Notes

Addressing it here - ensureShardingConfigured

I jumped into conclusion that there is actually a problem - but after checking in one of my local examples or testing pipeline we have currently #1992 - there seems to be no error.

Of course I agree this shouldn't happen - and some warning should be printed.

@vpavlin please, share details what actually fails?