chore: standardise exports to camel case
danisharora099 opened this issue · comments
This is a change request
Problem
We currently have camel case as well as snake case exports within our codebase:
Proposed Solutions
Standardise it to use camel case
Notes
- Related to #1913 (comment)
Can I start working on it?
of course @varunsh20 ! ping me if you need any help with it
sounds good -- let's confirm the scope of this issue before we move forward.
@waku-org/js-waku-developers are we deciding to stick with camel case?
also related: our file names are done in snake-case. how do we feel about that change? @weboko
there are already functions defined in these modules with the same name in camel casing, shall I rename those functions or rename the module name along with camel casing?
are we deciding to stick with camel case?
we already are using camel case almost everywhere for our code (as you noted - not files or packages tought)
our file names are done in snake-case
I think we can keep files for later to be changed, maybe as follow up @danisharora099
@varunsh20 good observation. To me it seems fine to rename waku_filter or other similar exports of a module to wakuFilterModule
cc @waku-org/js-waku-developers
Please review it and let me know if any changes are required.
@varunsh20 apologies for such long reply as our team had some activities this month. Ping if your are willing to complete this task or interested in contributing more!
@varunsh20 I had left a review on your PR #1934 (comment)
Hey @varunsh20 are you still interested in addressing comments on the PR? Mostly seems good, just need to ensure CI passes.
Up for grabs again