wagtail / wagtail-transfer

Content transfer for Wagtail

Home Page:https://wagtail.github.io/wagtail-transfer/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

wagtail_transfer_wagtail_hooks.py uses deprecated classnames when registering an admin menu item

maliahavlicek opened this issue · comments

Issue Summary

I am in the process of upgrading a project to wagtail 5.2 and updated all custom menu items in my project from classnames= to classname= but am still seeing the deprecation warning:

RemovedInWagtail60Warning: The `classnames` kwarg for MenuItem is deprecated - use `classname` instead.

Relevant Information

I have wagtail-transfer=0.9.2 installed, and when I put a breakpoint on the warning, I can see it traces back to wagtail-transfer:

image

I believe if you change Line 30 of /wagtail_transfer/wagtail_hooks.py to use classname the deprecation warning will go away.

Technical details

  • Python version: 3.11.1.
  • Django version: 4.1.13
  • Wagtail version: 5.2
  • Wagtail Transfer version: 0.9.2
  • Browser version: Chrome 119

Thanks for the report! There's already a PR addressing this - #157

Completed in #157 and released as 0.9.3.