waddlesplash / QMidi

Qt library for MIDI output & MIDI file I/O.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

QMidiFile::load gets stucked when parsing attached midi file

iv41879 opened this issue · comments

commented

It creates note on events in infinite loop. Actually file is broken and is only maybe partially loaded. Can we add some safety feature just to stop further loading and play what we have up to that tick?

qmidi-file-error

We Are The Champions.zip

Anvil Studio loads the file properly, but warns that it had errors. Will investigate.

(I probably should actually refactor this ancient code someday, there's probably a lot of other bugs like this one in it.)

commented

Thanks

commented

Actually, seems we have regression here from issue #3 .
So I restored old version of the code which now works for me - so when selecting corrupted file we had nice feature that we load events up to the place of the file damage - partial loading (same as vanBasco is doing). Now this code loads some dummy midi events. Please can you take a look.
So attached file is one that works for me now nicely.

QMidi.zip

Done.