wa0x6e / ResqueBoard

ResqueBoard is an analytics software for PHP Resque. Monitor your workers health and job activities in realtime

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

jquery dependency for GraphPie.js

mikeslim7 opened this issue · comments

I kept having a GraphPie related problem when i click on the Home button from another view. The problem was coming from:

GraphPie.js

...e=(b.parent().width()-2*d)/2...

and the error log in the console would be:
"...b.parent(...).width() is not a function..."

I think this is because the js is executed before jquery is loaded, especially if you are moving to the Home view from another view (It's not the first loading of the page).

I resolved the issue by modifying the header.ctp file to include jquery:

...
<link href="css/highlightjs/zenburn.css" rel="stylesheet" type="text/css">
        <script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>
        <script src="http://code.jquery.com/jquery-migrate-1.2.1.min.js"></script>
    </head>
...

I think it would be better to implement this in future releases. So jquery is always available. Or find a way to ensure that angular.js will always load jquery before running a function that needs it.

Thanks!

Regards,
Mike.

commented

Jquery is a dependency in Angular.js modules, so it "should" load before. Maybe there's something missing in the dependency in Require.js

Maybe related to #38 as well? I couldn't cause this issue but it would make sense given that the fix is to add jQuery as a dependency for angular.