Assign VideoFrame resource to [[resource reference]] in BufferSource constructor
Yahweasel opened this issue · comments
This is pedantic (hopefully in the way that spec issues should be pedantic).
In the VideoFrame constructor using a BufferSource, nothing actually assigns to [[resource reference]]. In 14.1 and 15.1, we let resource be a media resource, and in 17–20 we get some of its properties (its coded size), but there is no step to actually keep the resource after this algorithm, akin to AudioData's constructor's 4.10, “assign resourceReference to [[resource reference]]”.
This is done correctly in (I believe) every other algorithm that creates a VideoFrame, e.g. the "create a VideoFrame" algorithm, and even in the image source constructor, just not in the buffer source constructor. The constructor does not reference any algorithm to do this otherwise.
Yeah good catch, clearly an oversight, thanks for reporting. This is more like something incorrect rather than pedantic, it's kind of the goal of specifications to be quite specific.
Continuing the pedantry, every other resource assignment has resource reference as "a reference to" resource before assigning it, e.g.
Line 3835 in d5a4ed2
True, but it's all references on the Web, so it's correct.
True, but it's all references on the Web, so it's correct.
Exactly the opinion I had of all the other "reference to resource" mentions in the spec. Was this not going to be a reference? 🤣