w3c / did-test-suite

W3C DID Test Suite and Implementation Report

Home Page:https://w3c.github.io/did-test-suite/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix did:ethr resolver implementation

peacekeeper opened this issue · comments

@awoie you added a resolver implementation for did:ethr in #68, and it was temporarily disabled in c138027, since a number of tests are failing.

Some things to consider that are currently causing tests to fail on your implementation:

  • DID Core says in section "7. Resolution": "All conformant DID resolvers MUST implement the DID resolution functions for at least one DID method and MUST be able to return a DID document in at least one conformant representation".

--> If your implementation results only contain the "resolve" function, but not the "resolveRepresentation" function, then this test will fail.

  • DID Core says in section "7.1.2 DID Resolution Metadata" about "contentType": "This property MUST NOT be present if the resolve function was called."

--> If your implementation results include the "contentType" DID resolution metadata property for the "resolve" function, then this test will fail. This also causes a number of additional test failures.

  • DID Core says in section "7.1 DID Resolution" about "did": "This input is REQUIRED and the value MUST be a conformant DID as defined in § 3.1 DID Syntax."

--> If your implementation has something other than a plain DID (e.g. a DID URL with parameters) as input to the "resolve" or "resolveRepresentation" function, then this test will fail. In this case, you should probably consider the dereferencer test suite, not the resolver test suite.

Hope this helps. The example implementation reports may also clarify this further. Thanks for your efforts to submit an implementation report! Feel free to reply here if you need more help.

ping @awoie - update on this?

ping @awoie - update on this?

Thanks for the reminder, I'll fix this week.

Working on it today and should be fixed soon.

PR pending: #166