w3c / did-test-suite

W3C DID Test Suite and Implementation Report

Home Page:https://w3c.github.io/did-test-suite/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Symbols are confusing

brentzundel opened this issue · comments

In the implementation report, all normative statements are shown to be passing with green check marks except for specification statement 3.2.2 which has yellow triangles, but no mention is made in the document what this means.

It is clear that green check marks are good, and red x's are bad, but what does the yellow triangle mean? Is specification statement 3.2.2 implemented or not?

@shigeya @OR13 @msporny

It is clear that green check marks are good, and red x's are bad, but what does the yellow triangle mean? Is specification statement 3.2.2 implemented or not?

I believe that is a feature that @shigeya added... and I don't know what it means. :)

The mark only appears when the test case is todo.

For the 3.2.2, this line is the cause:

it.todo('3.2.2 Relative DID URLs - When resolving a relative DID URL reference, the algorithm specified in RFC3986 Section 5: Reference Resolution MUST be used.');

As with other non-testable statements, we can safely remove this line.

It's the only test line with todo in the entire test code (checked).

As I remember, I'm not the person who picked the emoji. Maybe we want to use a different one.

It's the only test line with todo in the entire test code (checked).

Ah, I see. We shouldn't have "TODO" at this point, we can safely remove that todo.

Raised PR #196 to address this.

As with other non-testable statements,

Hmm is this really untestable..?

For now, I think the best thing to do is remove the todo line, because it results in some confusion in the implementation report.

Then someone can write a test for it, if they determine that the statement is in fact testable.