w3c / did-test-suite

W3C DID Test Suite and Implementation Report

Home Page:https://w3c.github.io/did-test-suite/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Valid id property value throws in test runs

csuwildcat opened this issue · comments

In ION we use relative refs for id property values (for example: #key-0) in Verification Method entries and Relationship prop arrays, but the test runner is throwing on those values. I was under the impression these are valid values, so I think there may be an issue with that test.

Here is an example from element of the same expectation...

{
  "id": "did:elem:ropsten:EiBVk9F3eLf2u9xwLJ91-vTIXD-B7Q4m3iGhCbB2OyRiwQ",
  "@context": [
    "https://www.w3.org/ns/did/v1",
    "https://w3id.org/security/suites/jws-2020/v1"
  ],
  "verificationMethod": [
    {
      "id": "#z6MkqDbQmpZ825F8H6cBAqR8PUnZrcA2ykdtZ61iDwvM5pDS",
      "controller": "did:elem:ropsten:EiBVk9F3eLf2u9xwLJ91-vTIXD-B7Q4m3iGhCbB2OyRiwQ",
      "type": "JsonWebKey2020",
      "publicKeyJwk": {
        "crv": "Ed25519",
        "kid": "T70vcG-qIY4VNvS9LOJZsLs8dA31gyGmab7Ta_WE6N8",
        "kty": "OKP",
        "x": "n_BSOLvzjAHUCrkGLrz3VJsU6YygQr9k-59K6LxHcO0"
      }
    },
    {
      "id": "#z6LSj6RuiS4C2jG3oSRPatA92LFfjqbAj1tVC9D3sKXRtKK2",
      "controller": "did:elem:ropsten:EiBVk9F3eLf2u9xwLJ91-vTIXD-B7Q4m3iGhCbB2OyRiwQ",
      "type": "JsonWebKey2020",
      "publicKeyJwk": {
        "crv": "X25519",
        "kty": "OKP",
        "x": "bjhrdjJ-2n-XWaaJRFbOcqZQ5koJ58Ldql7Fj94auFU"
      }
    }
  ],
  "authentication": ["#z6MkqDbQmpZ825F8H6cBAqR8PUnZrcA2ykdtZ61iDwvM5pDS"],
  "assertionMethod": ["#z6MkqDbQmpZ825F8H6cBAqR8PUnZrcA2ykdtZ61iDwvM5pDS"],
  "capabilityInvocation": ["#z6MkqDbQmpZ825F8H6cBAqR8PUnZrcA2ykdtZ61iDwvM5pDS"],
  "capabilityDelegation": ["#z6MkqDbQmpZ825F8H6cBAqR8PUnZrcA2ykdtZ61iDwvM5pDS"],
  "keyAgreement": ["#z6LSj6RuiS4C2jG3oSRPatA92LFfjqbAj1tVC9D3sKXRtKK2"],
  "service": [
    {
      "id": "#resolver-0",
      "type": "Resolver",
      "serviceEndpoint": "https://example.com"
    }
  ]
}

Addressed this issue in PR #123. It only allowed absolute DID URL.

@csuwildcat would appear your issue has been resolved, when you update your PR, lmk if I can close this.

This is resolved, closing.