w3c-ccg / vc-api-issuer-test-suite

Test Suite for Issuers that implement the VC HTTP API

Home Page:https://w3c-ccg.github.io/vc-api-issuer-test-suite/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Syntactic comparison of expected and actual result

filip26 opened this issue · comments

commented

Hi,
it seems that the suite compares expected and actual result on syntactic level, that negates the advantage of using JSON-LD and, in some cases, complicates using JSON-LD processor.

This is an example of valid credentials compacted using a standardized JSON-LD algorithm. Notice the sec:proof property that is valid but the suite reports missing proof object.

{
  "id": "https://apicatalog/com/vc/test-credentials#0001",
  "type": "VerifiableCredential",
  "issuer": "https://github.com/filip26/iron-verifiable-credentials/issuer/1",
  "issuanceDate": "2022-06-03T21:18:40Z",
  "credentialSubject": "did:example:ebfeb1f712ebc6f1c276e12ec21",
  "sec:proof":{
    "type": "Ed25519Signature2020",
    "verificationMethod":{
      "id": "https://vc.apicatalog.com/key/test.json",
      "type": "Ed25519VerificationKey2020"
    },
    "proofValue": "zuBDMkNLx5pWncvikKbDqCcKqPTWLHbjFLsTE61ZNtBL2KeFALSyK8hqMrMAV8WapT15Hs1HdJBfxwygtNBHDPmW"
  },
  "@context":[
    "https://www.w3.org/2018/credentials/v1",
    "https://w3id.org/security/suites/ed25519-2020/v1"
  ]
}

Easy solution is to compare JSON-LD documents in the expanded form.

commented

I'm sorry, wrong suite, belongs to https://github.com/w3c-ccg/di-ed25519-test-suite