w11k / angular-sticky-things

Sticky Directive for Angular 2+

Home Page:https://w11k.github.io/angular-sticky-things

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Odd behavior inside the library.

EliezerB123 opened this issue · comments

Hi! I was looking over the code as reference for writing a library for my private work, and I noticed something odd.

sticky-thing.directive.ts

It seems that this.sticky is always false if there's no scrollContainer.

Which means that if there's no container, then determineElementOffsets() won't remove sticky before doing its math.

Is this intended behavior?

Edit: Oh. I see. this.sticky controls whether it uses position:sticky or position:fixed. Okay. So it is working as intended....... Except why would you need to turn off position:sticky, but not position:fixed before running determineElementOffsets()?