Giters

w11k / angular-sticky-things

Sticky Directive for Angular 2+

Home Page:https://w11k.github.io/angular-sticky-things

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error: Can't resolve 'codelyzer/util/isNotNullOrUndefined'

MustafaElKhalifa opened this issue · comments

commented

ERROR in ./node_modules/@w11k/angular-sticky-things/fesm5/w11k-angular-sticky-things.js
Module not found: Error: Can't resolve 'codelyzer/util/isNotNullOrUndefined' in 'E:\xampp\htdocs\webzz\dommania\shop.panel\node_modules@w11k\angular-sticky-things\fesm5'
i ｢wdm｣: Failed to compile.

commented

Hello! I have the same issue(
Can't resolve 'codelyzer/util/isNotNullOrUndefined'

commented

I'm also dealing the same problem

ERROR in ./node_modules/@w11k/angular-sticky-things/fesm5/w11k-angular-sticky-things.js
Module not found: Error: Can't resolve 'codelyzer/util/isNotNullOrUndefined'

commented

isNullOrUndefined is deprecated (https://nodejs.org/api/util.html#util_util_isnullorundefined_object). I am going to look into it and see if there is a quick, easy fix

commented

Remove import { isNotNullOrUndefined } from 'codelyzer/util/isNotNullOrUndefined'; from w11k-angular-sticky-things.js.

Change lines 345 and 347, removing the use of isNotNullOrUndefined:

var reachedLowerEdge = isNotNullOrUndefined(this.boundaryElement) ? this.boundaryElement && window.pageYOffset + stickyElementHeight + marginBottom >= (originalVals.bottomBoundary - marginTop * 1.0) : undefined;

should be changed to

var reachedLowerEdge = (this.boundaryElement!=null) ? this.boundaryElement && window.pageYOffset + stickyElementHeight + marginBottom >= (originalVals.bottomBoundary - marginTop * 1.0) : undefined;

Make the same change to the line with reachedUpperEdge

I can make a pull request sometime later today

commented

Hello @MustafaElKhalifa, @AndrewN93, @DrineTN, @paulhewitt,

the problem seemed to be that ng-packagr wasn't able to guess the correct identifier for codelyzer/util/isNotNullOrUndefined when writing the UMD bundle. Providing the module identifier by using umdModuleIds in the library's package file should have solved the issue. Please check within v1.2.4.

@see here for further information

Kind regards,

@tobiasatw11k

commented

Hello, you still need to remove
import { isNotNullOrUndefined } from 'codelyzer/util/isNotNullOrUndefined';
at line 7 on w11k-angular-sticky-things.js

commented

I'm still having this error.

commented

@tobiasatw11k Yeah this is still happening with 1.2.4

commented

Hi @tobiasatw11k, I've just tried to install 1.2.4 and also got this error:

ERROR in ./node_modules/@w11k/angular-sticky-things/fesm5/w11k-angular-sticky-things.js
Module not found: Error: Can't resolve 'codelyzer/util/isNotNullOrUndefined'
commented

@tobiasatw11k , Can this be reopened. It is still occurring in latest 1.2.4. @paulhewitt 's fix works.

commented

Hello @kalani96746 and others, sorry for the delayed response. Lost it on the radar during Christmas days. Issue is now reopened. If @paulhewitt makes a pull request, I'd be very happy to merge it and release a new version.

commented

@tobiasatw11k I have been quite busy lately, but I will make a pull request as soon as I can! Hopefully it helps everybody out :)

commented

@tobiasatw11k
@paulhewitt
PR: #65

commented

Hello @MustafaElKhalifa, @AndrewN93, @DrineTN, @paulhewitt, @nutphi, @jorgecasariego, @jziggas, @DraganMileski, @mikerudd, @kalani96746 created a new release 1.2.5 with removed isNotNullOrUndefined function please check if error still exists. Thank you all for your patience on this one 🙂