If folder does not exist on a platform then it errors

Question

If folder does not exist on a platform then it errors

niftylettuce opened this issue 8 years ago · comments

I believe that if we pass useType to be network, and the path does not exist for the network folder, then we should return an empty array instead of throwing an error (because path.join and fs.readDir are reading a director that does not exist. Perhaps you could modify the code so that it checks fs.stats if the directory exists, and if not return an empty array.

Vu Tran · Answer 1 · Mon Oct 31 2016 14:26:23 GMT+0800 (China Standard Time)

This should be fixed in this patch here.

niftylettuce · Answer 2 · Mon Oct 31 2016 14:34:57 GMT+0800 (China Standard Time)

thank you very much for the speed with these, it's really nice to hear back so quick and to have your help. I'm using this for https://github.com/crocodilejs/custom-fonts-in-emails which I'm writing tests for now (the Readme has changed a lot since I pushed initial commit)

Vu Tran · Answer 3 · Mon Oct 31 2016 15:02:46 GMT+0800 (China Standard Time)

@niftylettuce That's a pretty cool project you have there. Would be super useful to generate custom buttons. Looking forward to see your module take shape and mature.