vue-polkadot / ui

UI utilities, libraries and Vue.js components in use across @polkadot-js projects

Home Page:https://vue-polkadot.js.org/ui

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BOUNTY: Fix build of Vue identicon

vikiival opened this issue · comments

Proposal

The Goal of this bounty is to fix build of vue-identicon.
As you can see on the image below, <Identicon /> does not render and shows error that $attrs and $listeners are read only.

Maybe two Vue istances are there ?

photo_2020-03-05 18 27 07

Definition of done

I expect that:

  • Identicon would be working as expected - i.e. render like @polkadot/vue-identicon
  • You write short summary, how to build vue components on our Blog

We would be pleased if you use Vue Lib Build instead of Rollup.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it as part of the Web 3 Foundation fund.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 4 months from now.
Please review their action plans below:

1) x5engine has applied to start work (Funders only: approve worker | reject worker).

I can fix this, and make sure all identicons work as expected, and submit a short summary too with how to build the vue components properly!
2) psudoanon has applied to start work (Funders only: approve worker | reject worker).

Hey,

I have prior experience with Vue.js and shouldn't have any issues getting this resolved fairly quickly.

As far as the blog post is concerned, I'm assuming you'll want it in a similar style to the one already posted?

Thanks!
3) developerfred has applied to start work (Funders only: approve worker | reject worker).

my work plan and fix the component bug and create tests for this type of error not to happen in the future
4) snezanasucurovic042 has applied to start work (Funders only: approve worker | reject worker).

last year i wrote a paper about using Vue component to include Charts vue component in an app. it was paper for national conference and was marked as the begining work. I could translate the paper iin English and publish at your blog.
5) dushaobindoudou has applied to start work (Funders only: approve worker | reject worker).

  1. Vue development experience
  2. Some understanding of polkadot
    6) ryan-gordon has been approved to start work.

I will submit a PR to fix the issue in the linked screenshot.
I will also create a repo showing myself using vue-identicon.
On the docs page there is already an example of using vue-identicon, let me know what you need for DoD item 2
7) hunghus has applied to start work (Funders only: approve worker | reject worker).

Hello, nice to meet. It'd be my honor to help you. Here are some of my steps to get closer to our work:

  • Receive project
  • Analysis the project
  • Build plan
  • Sign contract
  • Pay 20%
  • Start working
  • Demo
  • Edit and maintenance
  • Pay 60%
  • Finish
  • Pay 20%

Learn more on the Gitcoin Issue Details page.

Hi is this issue still open?
I had previously tried to solve an issue for polkadot and so am familiar with code and have quite a vuejs experience. Is it fixed or still required?

@vikiival @yangwao
I have created a PR which fixes the issue when I run the polkadot/apps repo. The issue appears to be unrelated to this repo but in how vue-identicon is used by the apps repo.

I expressed interest in working on the issue in gitcoin also and will 'Submit Work' once approved. Merging the PR I created will auto close this issue.
I have also created a repo using vue-identicon on my page : https://github.com/Ryan-Gordon/vue-identicon-example

commented

@vikiival @yangwao Who do you want to approve to work on the issue?

commented

@vikiival @yangwao Any preferred worker for this issue?

Hello @Web3Foundation
@Ryan-Gordon looks good to me, he submitted PR elsewhere and we are gonna review it.

@Ryan-Gordon PR looks great, just do rebase against develop branch.

To second point, can you add a short tutorial on how to build Vue identicon component to https://vue-polkadot.js.org/vue-ui/vue-identicon/ ?

It's Vuepress, markdown, should be super easy https://github.com/vue-polkadot/vue-ui/tree/master/docs :)

To second point, can you add a short tutorial on how to build Vue identicon component to https://vue-polkadot.js.org/vue-ui/vue-identicon/ ?

I can do this, there is some info there already so I will try to expand it where I can. Will update you once I have it up as a PR.

@yangwao
I have updated the docs with a short tutorial on the component, how to install on NPM vs Yarn, 2 examples and a piece on how to use this component in a new Vue App.

Let me know if something needs to be different.
The PR on vue-polkadot/apps is now based off develop branch 👍

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by:

  1. @ryan-gordon

@Web3Foundation please take a look at the submitted work:


PRs merged which closed this issue.
Thank you for the opportunity @yangwao and @vikiival !
I am around always if there are future issues that need taking care of. 👍

@Web3Foundation PR has been merged and this issue closed. Can we mark this as done?

@Ryan-Gordon sure, there will be another round https://github.com/vue-polkadot/apps/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Abounty

Feel free to look around:)

@Web3Foundation yes, issue has been resolved.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Ryan-Gordon.

commented

Hey @Ryan-Gordon Thanks for working on this issue. Please help us improve the W3F bounties by filling out this very short survey: https://info.polkadot.network/bounty-completion-satisfaction-survey

It'll take you a minute but can help greatly improve the program.

Thanks,
W3F